Issue 1421813008: Merge to XFA: Add format width and precision tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1421813008: Merge to XFA: Add format width and precision tests. (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Add format width and precision tests. This CL adds tests for the numeric conversion done when calculating the format percision and width fields. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1411973005 . (cherry picked from commit c9e76c09b9e7901823ac52a3705da235bd2abe24) Committed: https://pdfium.googlesource.com/pdfium/+/e6590c98c3e1bbbfa375316bce1f10d36ab6b5a2

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -0 lines)			Patch
	M	core/src/fxcrt/fx_basic_bstring_unittest.cpp	View		1 chunk	+76 lines, -0 lines	0 comments	Download
	M	core/src/fxcrt/fx_basic_wstring_unittest.cpp	View		1 chunk	+76 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

dsinclair

5 years, 1 month ago (2015-11-03 19:47:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e6590c98c3e1bbbfa375316bce1f10d36ab6b5a2 (presubmit successful).