Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411973005: Add format width and precision tests. (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add format width and precision tests. This CL adds tests for the numeric conversion done when calculating the format percision and width fields. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c9e76c09b9e7901823ac52a3705da235bd2abe24

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -0 lines) Patch
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 1 1 chunk +76 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring_unittest.cpp View 1 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dsinclair
PTAL.
5 years, 1 month ago (2015-11-03 15:47:27 UTC) #2
Tom Sepez
https://codereview.chromium.org/1411973005/diff/1/core/src/fxcrt/fx_basic_bstring_unittest.cpp File core/src/fxcrt/fx_basic_bstring_unittest.cpp (right): https://codereview.chromium.org/1411973005/diff/1/core/src/fxcrt/fx_basic_bstring_unittest.cpp#newcode609 core/src/fxcrt/fx_basic_bstring_unittest.cpp:609: CFX_ByteString str; Do these support the %*d syntax as ...
5 years, 1 month ago (2015-11-03 17:19:49 UTC) #3
Tom Sepez
On 2015/11/03 17:19:49, Tom Sepez wrote: > https://codereview.chromium.org/1411973005/diff/1/core/src/fxcrt/fx_basic_bstring_unittest.cpp > File core/src/fxcrt/fx_basic_bstring_unittest.cpp (right): > > https://codereview.chromium.org/1411973005/diff/1/core/src/fxcrt/fx_basic_bstring_unittest.cpp#newcode609 ...
5 years, 1 month ago (2015-11-03 17:27:38 UTC) #4
dsinclair
https://codereview.chromium.org/1411973005/diff/1/core/src/fxcrt/fx_basic_bstring_unittest.cpp File core/src/fxcrt/fx_basic_bstring_unittest.cpp (right): https://codereview.chromium.org/1411973005/diff/1/core/src/fxcrt/fx_basic_bstring_unittest.cpp#newcode609 core/src/fxcrt/fx_basic_bstring_unittest.cpp:609: CFX_ByteString str; On 2015/11/03 17:19:49, Tom Sepez wrote: > ...
5 years, 1 month ago (2015-11-03 18:50:08 UTC) #5
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-03 18:51:22 UTC) #6
dsinclair
5 years, 1 month ago (2015-11-03 19:34:35 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c9e76c09b9e7901823ac52a3705da235bd2abe24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698