Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5317)

Unified Diff: chrome/browser/ui/exclusive_access/exclusive_access_bubble.h

Issue 1421813005: Fullscreen bubble: Draw a white box around "ESC" in "Press ESC to exit". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@border-roundedrect
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/exclusive_access/exclusive_access_bubble.h
diff --git a/chrome/browser/ui/exclusive_access/exclusive_access_bubble.h b/chrome/browser/ui/exclusive_access/exclusive_access_bubble.h
index 90e48169699a618add2c4233d39c3325e387659a..de66381335312166fc4648be9de6e0266b0d4cfd 100644
--- a/chrome/browser/ui/exclusive_access/exclusive_access_bubble.h
+++ b/chrome/browser/ui/exclusive_access/exclusive_access_bubble.h
@@ -90,6 +90,8 @@ class ExclusiveAccessBubble : public gfx::AnimationDelegate {
base::string16 GetCurrentAllowButtonText() const;
// The following strings never change.
+ // This string *may* contain the name of the key surrounded in pipe characters
msw 2015/10/29 17:50:02 Instead of using pipe characters, consider using t
Matt Giuca 2015/11/09 06:35:12 The bars came about because Evan raised a concern
+ // ('|'), which should be drawn graphically as a key, not displayed literally.
base::string16 GetInstructionText() const;
// The Manager associated with this bubble.

Powered by Google App Engine
This is Rietveld 408576698