Fullscreen bubble: Draw a white box around "ESC" in "Press ESC to exit".

chrome/browser/ui/exclusive_access/exclusive_access_bubble.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_BUBBLE_H_
 #define CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_BUBBLE_H_
 
 #include "base/timer/timer.h"
 #include "chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.h"
 #include "ui/gfx/animation/animation_delegate.h"
@@ skipping 72 matching lines @@
   void Accept();
   // Denys the request. Can cause FullscreenExitBubble to be deleted.
   void Cancel();
 
   // The following strings may change according to the content type and URL.
   base::string16 GetCurrentMessageText() const;
   base::string16 GetCurrentDenyButtonText() const;
   base::string16 GetCurrentAllowButtonText() const;
 
   // The following strings never change.
+  // This string *may* contain the name of the key surrounded in pipe characters

[msw, 2015/10/29 17:50:02]

Instead of using pipe characters, consider using the variant of GetStringFUTF16
that returns the offset of the replaced parameters:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/base/l10n/l10n_...
and then this function can return the range of the 'esc' substring, and we won't
need the separate '*sentence' resource.

[Matt Giuca, 2015/11/09 06:35:12]

The bars came about because Evan raised a concern (in a separate email thread)
that we might want to avoid using substitutions here for localization reasons.
However since for the time being we are using substitutions, I guess we can
change this to use GetStringFUTF16 here.
We'll still need a separate "sentence" resource here regardless, and in fact
that is something I explicitly want. The old resources will be deleted once the
old behaviour flag is deleted. There are other differences between the two
strings -- one has a period while the other does not, and we want to be free to
experiment changing the "new" string without affecting the "old" string.

+  // ('|'), which should be drawn graphically as a key, not displayed literally.
   base::string16 GetInstructionText() const;
 
   // The Manager associated with this bubble.
   ExclusiveAccessManager* const manager_;
 
   // The host the bubble is for, can be empty.
   GURL url_;
 
   // The type of the bubble; controls e.g. which buttons to show.
   ExclusiveAccessBubbleType bubble_type_;
@@ skipping 24 matching lines @@
   base::RepeatingTimer mouse_position_checker_;
 
   // The most recently seen mouse position, in screen coordinates.  Used to see
   // if the mouse has moved since our last check.
   gfx::Point last_mouse_pos_;
 
   DISALLOW_COPY_AND_ASSIGN(ExclusiveAccessBubble);
 };
 
 #endif  // CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_BUBBLE_H_