chrome/common/extensions/docs/server2/github_file_system.py - Issue 14218004: Devserver: only populate data during cron jobs, meaning all data from instances

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/github_file_system.py

Issue 14218004: Devserver: only populate data during cron jobs, meaning all data from instances (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix integration test Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/file_system.py ('k') | chrome/common/extensions/docs/server2/github_file_system_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/github_file_system.py

diff --git a/chrome/common/extensions/docs/server2/github_file_system.py b/chrome/common/extensions/docs/server2/github_file_system.py

index 4f328cd3bf985c8697a81983f3406031e623e7fa..adbef9ed6f76cdaa9016d271e20553ae1ceb66d3 100644

--- a/chrome/common/extensions/docs/server2/github_file_system.py

+++ b/chrome/common/extensions/docs/server2/github_file_system.py

@@ -131,8 +131,11 @@ class GithubFileSystem(FileSystem):

def _DefaultStat(self, path):

version = 0

- # Cache for a minute so we don't try to keep fetching bad data.

- self._stat_object_store.Set(path, version, time=60)

+ # TODO(kalman): we should replace all of this by wrapping the

+ # GithubFileSystem in a CachingFileSystem. A lot of work has been put into

+ # CFS to be robust, and GFS is missing out.

+ # For example: the following line is wrong, but it could be moot.

+ self._stat_object_store.Set(path, version)

return StatInfo(version)

def Stat(self, path):