Devserver: only populate data during cron jobs, meaning all data from instances

chrome/common/extensions/docs/server2/github_file_system.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import logging
 import os
 
 import appengine_blobstore as blobstore
 from appengine_wrappers import urlfetch
@@ skipping 113 matching lines @@
     result = {}
     for path in paths:
       if path.endswith('/'):
         result[path] = self._ListDir(path)
       else:
         result[path] = self._ReadFile(path)
     return Future(value=result)
 
   def _DefaultStat(self, path):
     version = 0
-    # Cache for a minute so we don't try to keep fetching bad data.
-    self._stat_object_store.Set(path, version, time=60)
+    # TODO(kalman): we should replace all of this by wrapping the
+    # GithubFileSystem in a CachingFileSystem. A lot of work has been put into
+    # CFS to be robust, and GFS is missing out.
+    # For example: the following line is wrong, but it could be moot.
+    self._stat_object_store.Set(path, version)
     return StatInfo(version)
 
   def Stat(self, path):
     version = self._stat_object_store.Get(path).Get()
     if version is not None:
       return StatInfo(version)
     try:
       result = self._fetcher.Fetch('commits/HEAD',
                                    username=USERNAME,
                                    password=PASSWORD)
@@ skipping 12 matching lines @@
     version = (json.loads(result.content).get('commit', {})
                                          .get('tree', {})
                                          .get('sha', None))
     # Check if the JSON was valid, and set to 0 if not.
     if version is not None:
       self._stat_object_store.Set(path, version)
     else:
       logging.warning('Problem fetching commit hash from github.')
       return self._DefaultStat(path)
     return StatInfo(version)