Implement chrome://network-errors for direct access to network error interstitials

content/browser/webui/url_data_manager_backend_unittest.cc

Index: content/browser/webui/url_data_manager_backend_unittest.cc
diff --git a/content/browser/webui/url_data_manager_backend_unittest.cc b/content/browser/webui/url_data_manager_backend_unittest.cc
index 9a511f1e25d98ccf08655c099363c570ee5ab068..111be7c5a5f75867d97a2c52801568ec16dcc24c 100644
--- a/content/browser/webui/url_data_manager_backend_unittest.cc
+++ b/content/browser/webui/url_data_manager_backend_unittest.cc
@@ -107,4 +107,27 @@ TEST_F(UrlDataManagerBackendTest, CancelAfterFirstReadStarted) {
   EXPECT_EQ("", cancel_delegate.data_received());
 }
 
+// Check for a network error page request via chrome://network-error/.
+TEST_F(UrlDataManagerBackendTest, ChromeNetworkErrorPageRequest) {
+  scoped_ptr<net::URLRequest> error_request =
+        url_request_context_.CreateRequest(
+        GURL("chrome://network-errors/-105"), net::HIGHEST, &delegate_);
+  error_request->Start();
+  base::RunLoop().Run();
+  EXPECT_EQ(error_request->status().status(), net::URLRequestStatus::FAILED);
+  EXPECT_EQ(error_request->status().error(), net::ERR_NAME_NOT_RESOLVED);

[mmenke, 2015/11/24 22:42:35]

This test passes?  But you're not using kChromeUINetworkErrorHost...

[mmenke, 2015/11/24 22:42:35]

EXPECT_EQ(expected, actual) (x2)

[edwardjung, 2015/11/26 16:12:16]

My oversight. Hadn't updated the test.

[edwardjung, 2015/11/26 16:12:16]

Done.

+}
+
+// Check for an invalid network error page request via chrome://network-error/.
+TEST_F(UrlDataManagerBackendTest, ChromeNetworkErrorPageRequestFailed) {
+  scoped_ptr<net::URLRequest> error_request =
+        url_request_context_.CreateRequest(
+        GURL("chrome://network-errors/-123456789"), net::HIGHEST, &delegate_);
+  error_request->Start();
+  base::RunLoop().Run();
+  EXPECT_EQ(error_request->status().status(), net::URLRequestStatus::FAILED);
+  EXPECT_EQ(net::ErrorToShortString(error_request->status().error()),
+      "ERR_<unknown>");

[mmenke, 2015/11/24 22:42:35]

I don't think we want to be sending invalid error codes to blink - I'd rather
just return ERR_UNEXPECTED or a blank page or something on invalid error codes.

[mmenke, 2015/11/24 22:42:35]

EXPECT_EQ(expected, actual) (x2)

[edwardjung, 2015/11/26 16:12:16]

Changed so that it will now return ERR_INVALID_URL as per normal invalid URL
requests.

[edwardjung, 2015/11/26 16:12:16]

Done.

+}
+
 }  // namespace content