Implement chrome://network-errors for direct access to network error interstitials

content/browser/webui/url_data_manager_backend_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/run_loop.h"
 #include "content/browser/webui/url_data_manager_backend.h"
 #include "content/public/test/mock_resource_context.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "net/http/http_response_headers.h"
@@ skipping 89 matching lines @@
   scoped_ptr<net::URLRequest> request(
       CreateRequest(&cancel_delegate, "chrome://webui"));
   request->Start();
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(net::URLRequestStatus::CANCELED, request->status().status());
   EXPECT_EQ(1, cancel_delegate.response_started_count());
   EXPECT_EQ("", cancel_delegate.data_received());
 }
 
+// Check for a network error page request via chrome://network-error/.
+TEST_F(UrlDataManagerBackendTest, ChromeNetworkErrorPageRequest) {
+  scoped_ptr<net::URLRequest> error_request =
+        url_request_context_.CreateRequest(
+        GURL("chrome://network-errors/-105"), net::HIGHEST, &delegate_);
+  error_request->Start();
+  base::RunLoop().Run();
+  EXPECT_EQ(error_request->status().status(), net::URLRequestStatus::FAILED);
+  EXPECT_EQ(error_request->status().error(), net::ERR_NAME_NOT_RESOLVED);

[mmenke, 2015/11/24 22:42:35]

This test passes?  But you're not using kChromeUINetworkErrorHost...

[mmenke, 2015/11/24 22:42:35]

EXPECT_EQ(expected, actual) (x2)

[edwardjung, 2015/11/26 16:12:16]

My oversight. Hadn't updated the test.

[edwardjung, 2015/11/26 16:12:16]

Done.

+}
+
+// Check for an invalid network error page request via chrome://network-error/.
+TEST_F(UrlDataManagerBackendTest, ChromeNetworkErrorPageRequestFailed) {
+  scoped_ptr<net::URLRequest> error_request =
+        url_request_context_.CreateRequest(
+        GURL("chrome://network-errors/-123456789"), net::HIGHEST, &delegate_);
+  error_request->Start();
+  base::RunLoop().Run();
+  EXPECT_EQ(error_request->status().status(), net::URLRequestStatus::FAILED);
+  EXPECT_EQ(net::ErrorToShortString(error_request->status().error()),
+      "ERR_<unknown>");

[mmenke, 2015/11/24 22:42:35]

I don't think we want to be sending invalid error codes to blink - I'd rather
just return ERR_UNEXPECTED or a blank page or something on invalid error codes.

[mmenke, 2015/11/24 22:42:35]

EXPECT_EQ(expected, actual) (x2)

[edwardjung, 2015/11/26 16:12:16]

Changed so that it will now return ERR_INVALID_URL as per normal invalid URL
requests.

[edwardjung, 2015/11/26 16:12:16]

Done.

+}
+
 }  // namespace content