Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1421703002: Merge to XFA: Make DEPS use relative paths to fix recipe (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com, Oliver Chang
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Make DEPS use relative paths to fix recipe Context: DEPS was originally added to pdfium to allow its recipe to automatically check out its dependencies. The recipe used absolute paths, and so the checkout directory's name ('pdfium') had to be prefixed to the directory checkout of every dependency, as gclient in the recipe worked one level above the pdfium checkout itself. After change fe4537269fc7133320a5131638757f2ffa6bd854, the recipe no longer worked. To fix this, I'm making DEPS use relative paths. BUG=375773 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/724113003 (cherry picked from commit 39c6b4c50bb06336c2b592a407efa862ff6ed8ae) Committed: https://pdfium.googlesource.com/pdfium/+/e4bf83403b6791dda2afe3827a124df4f8c62237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
TBR, clean merge. Without this, gclient sync does not work right on XFA.
5 years, 2 months ago (2015-10-22 00:11:00 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as e4bf83403b6791dda2afe3827a124df4f8c62237 (presubmit successful).
5 years, 2 months ago (2015-10-22 00:11:08 UTC) #2
Tom Sepez
Any of the hashes need updating? LGTM otherwise.
5 years, 2 months ago (2015-10-22 00:12:46 UTC) #3
Lei Zhang
5 years, 2 months ago (2015-10-22 00:17:10 UTC) #4
Message was sent while issue was closed.
On 2015/10/22 00:12:46, Tom Sepez wrote:
> Any of the hashes need updating? LGTM otherwise.

Ya, v8 is out of date. I'll remember to merge the v8 rolls starting next week.

Powered by Google App Engine
This is Rietveld 408576698