Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 724113003: Make DEPS use relative paths to fix recipe (Closed)

Created:
6 years, 1 month ago by aneeshm1
Modified:
6 years, 1 month ago
Reviewers:
nodir, jam, Chris Palmer
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Visibility:
Public.

Description

Make DEPS use relative paths to fix recipe Context: DEPS was originally added to pdfium to allow its recipe to automatically check out its dependencies. The recipe used absolute paths, and so the checkout directory's name ('pdfium') had to be prefixed to the directory checkout of every dependency, as gclient in the recipe worked one level above the pdfium checkout itself. After change fe4537269fc7133320a5131638757f2ffa6bd854, the recipe no longer worked. To fix this, I'm making DEPS use relative paths. BUG=375773 R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/39c6b4c50bb06336c2b592a407efa862ff6ed8ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
aneeshm1
I need this change for the pdfium Buildbot to work. PTAL.
6 years, 1 month ago (2014-11-13 21:49:28 UTC) #2
jam
On 2014/11/13 21:49:28, aneeshm1 wrote: > I need this change for the pdfium Buildbot to ...
6 years, 1 month ago (2014-11-13 21:57:52 UTC) #3
aneeshm1
6 years, 1 month ago (2014-11-13 21:59:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
39c6b4c50bb06336c2b592a407efa862ff6ed8ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698