Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421693002: Plugin Power Saver: Do not always throttle plugins with posters. (Closed)

Created:
5 years, 2 months ago by tommycli
Modified:
5 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@0025-pps-poster-pixel-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Do not always throttle plugins with posters. Previously, all plugins with the <object poster> attribute were throttled. This was a misdesign. Now, plugins with posters are subject to the same heuristics as all plugins. BUG=543852 Committed: https://crrev.com/bae63b997c9b91b775b039cc2254822dd24be26d Cr-Commit-Position: refs/heads/master@{#355714}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -98 lines) Patch
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 2 3 4 5 2 chunks +32 lines, -5 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 1 2 3 4 3 chunks +25 lines, -16 lines 0 comments Download
M content/public/renderer/plugin_instance_throttler.h View 1 2 3 4 2 chunks +1 line, -4 lines 0 comments Download
M content/public/renderer/render_frame.h View 1 2 3 4 5 1 chunk +30 lines, -0 lines 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl.cc View 1 2 3 4 4 chunks +3 lines, -10 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper.h View 2 chunks +13 lines, -34 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper_browsertest.cc View 6 chunks +22 lines, -26 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 5 1 chunk +7 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421693002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421693002/60001
5 years, 2 months ago (2015-10-22 00:08:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421693002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421693002/100001
5 years, 2 months ago (2015-10-22 00:42:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 01:54:43 UTC) #6
tommycli
piman: PTAL, thanks!
5 years, 2 months ago (2015-10-22 20:50:48 UTC) #8
piman
lgtm
5 years, 2 months ago (2015-10-23 00:58:07 UTC) #9
tommycli
piman: thanks!
5 years, 2 months ago (2015-10-23 01:02:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421693002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421693002/100001
5 years, 2 months ago (2015-10-23 01:03:19 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 2 months ago (2015-10-23 02:56:27 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 02:57:53 UTC) #14
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/bae63b997c9b91b775b039cc2254822dd24be26d
Cr-Commit-Position: refs/heads/master@{#355714}

Powered by Google App Engine
This is Rietveld 408576698