Plugin Power Saver: Do not always throttle plugins with posters.

content/renderer/pepper/plugin_power_saver_helper_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "content/common/frame_messages.h"
 #include "content/common/view_message_enums.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/test/frame_load_waiter.h"
 #include "content/public/test/render_view_test.h"
@@ skipping 15 matching lines @@
 
   void SetUp() override {
     RenderViewTest::SetUp();
     sink_ = &render_thread_->sink();
   }
 
   RenderFrameImpl* frame() {
     return static_cast<RenderFrameImpl*>(view_->GetMainRenderFrame());
   }
 
-  PluginPowerSaverHelper* helper() {
-    return frame()->plugin_power_saver_helper();
-  }
-
   blink::WebPluginParams MakeParams(const std::string& url,
                                     const std::string& poster,
                                     const std::string& width,
                                     const std::string& height) {
     const size_t size = 3;
     blink::WebVector<blink::WebString> names(size);
     blink::WebVector<blink::WebString> values(size);
 
     blink::WebPluginParams params;
     params.url = GURL(url);
@@ skipping 12 matching lines @@
   }
 
  protected:
   IPC::TestSink* sink_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginPowerSaverHelperTest);
 };
 
 TEST_F(PluginPowerSaverHelperTest, AllowSameOrigin) {
   EXPECT_FALSE(
-      helper()->ShouldThrottleContent(url::Origin(GURL("http://same.com")),
-                                      url::Origin(GURL("http://same.com")),
-                                      kFlashPluginName, 100, 100, nullptr));
+      frame()->ShouldThrottleContent(url::Origin(GURL("http://same.com")),
+                                     url::Origin(GURL("http://same.com")),
+                                     kFlashPluginName, 100, 100, nullptr));
   EXPECT_FALSE(
-      helper()->ShouldThrottleContent(url::Origin(GURL("http://same.com")),
-                                      url::Origin(GURL("http://same.com")),
-                                      kFlashPluginName, 1000, 1000, nullptr));
+      frame()->ShouldThrottleContent(url::Origin(GURL("http://same.com")),
+                                     url::Origin(GURL("http://same.com")),
+                                     kFlashPluginName, 1000, 1000, nullptr));
 }
 
 TEST_F(PluginPowerSaverHelperTest, DisallowCrossOriginUnlessLarge) {
   bool cross_origin_main_content = false;
-  EXPECT_TRUE(helper()->ShouldThrottleContent(
+  EXPECT_TRUE(frame()->ShouldThrottleContent(
       url::Origin(GURL("http://same.com")),
       url::Origin(GURL("http://other.com")), kFlashPluginName, 100, 100,
       &cross_origin_main_content));
   EXPECT_FALSE(cross_origin_main_content);
 
-  EXPECT_FALSE(helper()->ShouldThrottleContent(
+  EXPECT_FALSE(frame()->ShouldThrottleContent(
       url::Origin(GURL("http://same.com")),
       url::Origin(GURL("http://other.com")), kFlashPluginName, 1000, 1000,
       &cross_origin_main_content));
   EXPECT_TRUE(cross_origin_main_content);
 }
 
 TEST_F(PluginPowerSaverHelperTest, AlwaysAllowTinyContent) {
   bool cross_origin_main_content = false;
-  EXPECT_FALSE(helper()->ShouldThrottleContent(
+  EXPECT_FALSE(frame()->ShouldThrottleContent(
       url::Origin(GURL("http://same.com")),
       url::Origin(GURL("http://same.com")), kFlashPluginName, 1, 1, nullptr));
   EXPECT_FALSE(cross_origin_main_content);
 
-  EXPECT_FALSE(helper()->ShouldThrottleContent(
+  EXPECT_FALSE(frame()->ShouldThrottleContent(
       url::Origin(GURL("http://same.com")),
       url::Origin(GURL("http://other.com")), kFlashPluginName, 1, 1,
       &cross_origin_main_content));
   EXPECT_FALSE(cross_origin_main_content);
 
-  EXPECT_FALSE(helper()->ShouldThrottleContent(
+  EXPECT_FALSE(frame()->ShouldThrottleContent(
       url::Origin(GURL("http://same.com")),
       url::Origin(GURL("http://other.com")), kFlashPluginName, 5, 5,
       &cross_origin_main_content));
   EXPECT_FALSE(cross_origin_main_content);
 
-  EXPECT_TRUE(helper()->ShouldThrottleContent(
+  EXPECT_TRUE(frame()->ShouldThrottleContent(
       url::Origin(GURL("http://same.com")),
       url::Origin(GURL("http://other.com")), kFlashPluginName, 10, 10,
       &cross_origin_main_content));
   EXPECT_FALSE(cross_origin_main_content);
 }
 
 TEST_F(PluginPowerSaverHelperTest, TemporaryOriginWhitelist) {
   bool cross_origin_main_content = false;
-  EXPECT_TRUE(helper()->ShouldThrottleContent(
+  EXPECT_TRUE(frame()->ShouldThrottleContent(
       url::Origin(GURL("http://same.com")),
       url::Origin(GURL("http://other.com")), kFlashPluginName, 100, 100,
       &cross_origin_main_content));
   EXPECT_FALSE(cross_origin_main_content);
 
   // Clear out other messages so we find just the plugin power saver IPCs.
   sink_->ClearMessages();
 
-  helper()->WhitelistContentOrigin(url::Origin(GURL("http://other.com")));
-  EXPECT_FALSE(helper()->ShouldThrottleContent(
+  frame()->WhitelistContentOrigin(url::Origin(GURL("http://other.com")));
+  EXPECT_FALSE(frame()->ShouldThrottleContent(
       url::Origin(GURL("http://same.com")),
       url::Origin(GURL("http://other.com")), kFlashPluginName, 100, 100,
       &cross_origin_main_content));
   EXPECT_FALSE(cross_origin_main_content);
 
   // Test that we've sent an IPC to the browser.
   ASSERT_EQ(1u, sink_->message_count());
   const IPC::Message* msg = sink_->GetMessageAt(0);
   EXPECT_EQ(FrameHostMsg_PluginContentOriginAllowed::ID, msg->type());
   FrameHostMsg_PluginContentOriginAllowed::Param params;
@@ skipping 10 matching lines @@
   std::set<url::Origin> origin_whitelist;
   origin_whitelist.insert(url::Origin(GURL("http://other.com")));
   frame()->OnMessageReceived(FrameMsg_UpdatePluginContentOriginWhitelist(
       frame()->GetRoutingID(), origin_whitelist));
 
   // Runs until the unthrottle closure is run.
   loop.Run();
 }
 
 TEST_F(PluginPowerSaverHelperTest, ClearWhitelistOnNavigate) {
-  helper()->WhitelistContentOrigin(url::Origin(GURL("http://other.com")));
+  frame()->WhitelistContentOrigin(url::Origin(GURL("http://other.com")));
 
   EXPECT_FALSE(
-      helper()->ShouldThrottleContent(url::Origin(GURL("http://same.com")),
-                                      url::Origin(GURL("http://other.com")),
-                                      kFlashPluginName, 100, 100, nullptr));
+      frame()->ShouldThrottleContent(url::Origin(GURL("http://same.com")),
+                                     url::Origin(GURL("http://other.com")),
+                                     kFlashPluginName, 100, 100, nullptr));
 
   LoadHTML("<html></html>");
 
   EXPECT_TRUE(
-      helper()->ShouldThrottleContent(url::Origin(GURL("http://same.com")),
-                                      url::Origin(GURL("http://other.com")),
-                                      kFlashPluginName, 100, 100, nullptr));
+      frame()->ShouldThrottleContent(url::Origin(GURL("http://same.com")),
+                                     url::Origin(GURL("http://other.com")),
+                                     kFlashPluginName, 100, 100, nullptr));
 }
 
 }  // namespace content