Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1421593009: Revert of Use in-object fields instead of private symbols for regexp slots. (Closed)

Created:
5 years, 1 month ago by Michael Hablich
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use in-object fields instead of private symbols for regexp slots. (patchset #4 id:60001 of https://codereview.chromium.org/1428203003/ ) Reason for revert: A clean revert of https://codereview.chromium.org/1419823010/ was not possible because of this CL. Thus, I am also reverting this CL. Original issue's description: > Use in-object fields instead of private symbols for regexp slots. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e > Cr-Commit-Position: refs/heads/master@{#31791} TBR=bmeurer@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/626fd5f0b9269011124d0bc1b14348502c029872 Cr-Commit-Position: refs/heads/master@{#31800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -82 lines) Patch
M src/bootstrapper.cc View 1 chunk +26 lines, -9 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/js/macros.py View 1 chunk +6 lines, -6 lines 0 comments Download
M src/js/regexp.js View 3 chunks +14 lines, -4 lines 0 comments Download
M src/js/string.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 3 chunks +5 lines, -7 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Hablich
Created Revert of Use in-object fields instead of private symbols for regexp slots.
5 years, 1 month ago (2015-11-04 18:32:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421593009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421593009/1
5 years, 1 month ago (2015-11-04 18:32:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421593009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421593009/1
5 years, 1 month ago (2015-11-04 18:32:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 18:32:57 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 18:33:33 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/626fd5f0b9269011124d0bc1b14348502c029872
Cr-Commit-Position: refs/heads/master@{#31800}

Powered by Google App Engine
This is Rietveld 408576698