Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: src/crankshaft/hydrogen.cc

Issue 1421593009: Revert of Use in-object fields instead of private symbols for regexp slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.h ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen.h" 5 #include "src/crankshaft/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/allocation-site-scopes.h" 9 #include "src/allocation-site-scopes.h"
10 #include "src/ast-numbering.h" 10 #include "src/ast-numbering.h"
(...skipping 12626 matching lines...) Expand 10 before | Expand all | Expand 10 after
12637 // Support for direct calls from JavaScript to native RegExp code. 12637 // Support for direct calls from JavaScript to native RegExp code.
12638 void HOptimizedGraphBuilder::GenerateRegExpExec(CallRuntime* call) { 12638 void HOptimizedGraphBuilder::GenerateRegExpExec(CallRuntime* call) {
12639 DCHECK_EQ(4, call->arguments()->length()); 12639 DCHECK_EQ(4, call->arguments()->length());
12640 CHECK_ALIVE(VisitExpressions(call->arguments())); 12640 CHECK_ALIVE(VisitExpressions(call->arguments()));
12641 PushArgumentsFromEnvironment(call->arguments()->length()); 12641 PushArgumentsFromEnvironment(call->arguments()->length());
12642 HCallStub* result = New<HCallStub>(CodeStub::RegExpExec, 4); 12642 HCallStub* result = New<HCallStub>(CodeStub::RegExpExec, 4);
12643 return ast_context()->ReturnInstruction(result, call->id()); 12643 return ast_context()->ReturnInstruction(result, call->id());
12644 } 12644 }
12645 12645
12646 12646
12647 void HOptimizedGraphBuilder::GenerateRegExpFlags(CallRuntime* call) {
12648 DCHECK_EQ(1, call->arguments()->length());
12649 CHECK_ALIVE(VisitExpressions(call->arguments()));
12650 HValue* regexp = Pop();
12651 HInstruction* result =
12652 New<HLoadNamedField>(regexp, nullptr, HObjectAccess::ForJSRegExpFlags());
12653 return ast_context()->ReturnInstruction(result, call->id());
12654 }
12655
12656
12657 void HOptimizedGraphBuilder::GenerateRegExpSource(CallRuntime* call) {
12658 DCHECK_EQ(1, call->arguments()->length());
12659 CHECK_ALIVE(VisitExpressions(call->arguments()));
12660 HValue* regexp = Pop();
12661 HInstruction* result =
12662 New<HLoadNamedField>(regexp, nullptr, HObjectAccess::ForJSRegExpSource());
12663 return ast_context()->ReturnInstruction(result, call->id());
12664 }
12665
12666
12667 void HOptimizedGraphBuilder::GenerateDoubleLo(CallRuntime* call) { 12647 void HOptimizedGraphBuilder::GenerateDoubleLo(CallRuntime* call) {
12668 DCHECK_EQ(1, call->arguments()->length()); 12648 DCHECK_EQ(1, call->arguments()->length());
12669 CHECK_ALIVE(VisitForValue(call->arguments()->at(0))); 12649 CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));
12670 HValue* value = Pop(); 12650 HValue* value = Pop();
12671 HInstruction* result = NewUncasted<HDoubleBits>(value, HDoubleBits::LOW); 12651 HInstruction* result = NewUncasted<HDoubleBits>(value, HDoubleBits::LOW);
12672 return ast_context()->ReturnInstruction(result, call->id()); 12652 return ast_context()->ReturnInstruction(result, call->id());
12673 } 12653 }
12674 12654
12675 12655
12676 void HOptimizedGraphBuilder::GenerateDoubleHi(CallRuntime* call) { 12656 void HOptimizedGraphBuilder::GenerateDoubleHi(CallRuntime* call) {
(...skipping 1024 matching lines...) Expand 10 before | Expand all | Expand 10 after
13701 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13681 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13702 } 13682 }
13703 13683
13704 #ifdef DEBUG 13684 #ifdef DEBUG
13705 graph_->Verify(false); // No full verify. 13685 graph_->Verify(false); // No full verify.
13706 #endif 13686 #endif
13707 } 13687 }
13708 13688
13709 } // namespace internal 13689 } // namespace internal
13710 } // namespace v8 13690 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.h ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698