Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1421553014: Create the D3D device with a NULL HWND instead of GetShellWindow in the decoder (Closed)

Created:
5 years, 1 month ago by ananta
Modified:
5 years, 1 month ago
Reviewers:
DaleCurtis, jbauman
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create the D3D device with a NULL HWND instead of GetShellWindow in the decoder This works correctly on Windows 7 and 8 and the reason for doing this is to see if this is causing crashes in device creation in certain configurations in the wild. BUG=551068 Committed: https://crrev.com/0b0477349b8cdd69e968358e99180be9ad03d956 Cr-Commit-Position: refs/heads/master@{#358370}

Patch Set 1 #

Patch Set 2 : Revert change to the Windowed flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ananta
5 years, 1 month ago (2015-11-06 02:05:08 UTC) #2
jbauman
lgtm
5 years, 1 month ago (2015-11-06 02:06:08 UTC) #3
DaleCurtis
lgtm
5 years, 1 month ago (2015-11-06 18:18:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421553014/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421553014/20001
5 years, 1 month ago (2015-11-06 18:52:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 19:07:51 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 19:09:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b0477349b8cdd69e968358e99180be9ad03d956
Cr-Commit-Position: refs/heads/master@{#358370}

Powered by Google App Engine
This is Rietveld 408576698