Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 1421553011: Updated to include profiler again in stack trace (Closed)

5 years, 1 month ago by terry
5 years, 1 month ago
Bill Hesse
Target Ref:


Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M LayoutTests/dart/inspector/scope-variables-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download


Total messages: 3 (0 generated)
Committed patchset #1 (id:1) manually as 202695 (tree was closed).
5 years, 1 month ago (2015-11-05 14:47:05 UTC) #1
Bill Hesse
5 years, 1 month ago (2015-11-05 14:52:02 UTC) #2
Bill Hesse
5 years, 1 month ago (2015-11-05 14:59:51 UTC) #3
Message was sent while issue was closed.
On 2015/11/05 14:52:02, Bill Hesse wrote:
> lgtm

If we want to update the expectations on the stable channel, we should also push
this change to the webkit stable branch we created.  I'm think it is worth it in
this case, and then a DEPS update for stable (we will be on stable by that
point) to the new webkit, which is not a cherry-pick from bleeding-edge, should
be created - a merge-to-stable issue filed, with a CL created on the stable
branch to do it.

It is worth it in this case, because we may have many patches to stable, and
this is the one issue turning columns red on dev/stable.  So also merge this to
webkit stable, and create the CL for stable branch.

Powered by Google App Engine
This is Rietveld 408576698