Issue 1421553011: Updated to include profiler again in stack trace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1421553011: Updated to include profiler again in stack trace (Closed)

Created:
5 years, 1 month ago by terry

Modified:
5 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/blink/branches/dart/dartium

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Updated to include profiler again in stack trace TBR=whesse@google.com Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=202695

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	LayoutTests/dart/inspector/scope-variables-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

terry

Committed patchset #1 (id:1) manually as 202695 (tree was closed).

5 years, 1 month ago (2015-11-05 14:47:05 UTC) #1

Bill Hesse

5 years, 1 month ago (2015-11-05 14:59:51 UTC) #3

Message was sent while issue was closed.

On 2015/11/05 14:52:02, Bill Hesse wrote:
> lgtm

If we want to update the expectations on the stable channel, we should also push
this change to the webkit stable branch we created.  I'm think it is worth it in
this case, and then a DEPS update for stable (we will be on stable by that
point) to the new webkit, which is not a cherry-pick from bleeding-edge, should
be created - a merge-to-stable issue filed, with a CL created on the stable
branch to do it.

It is worth it in this case, because we may have many patches to stable, and
this is the one issue turning columns red on dev/stable.  So also merge this to
webkit stable, and create the CL for stable branch.

Expand Messages | Collapse Messages