third_party/WebKit/Source/core/css/MediaValues.cpp - Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaValues.cpp

Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/MediaValues.cpp

diff --git a/third_party/WebKit/Source/core/css/MediaValues.cpp b/third_party/WebKit/Source/core/css/MediaValues.cpp

index 3fb45985deba8db39a43ad2c22c210fba13b1e92..294df98397efd6f9b0d41719738fdfc098939d3f 100644

--- a/third_party/WebKit/Source/core/css/MediaValues.cpp

+++ b/third_party/WebKit/Source/core/css/MediaValues.cpp

@@ -167,6 +167,7 @@ bool MediaValues::computeLengthImpl(double value, CSSPrimitiveValue::UnitType ty

factor = defaultFontSize;

break;

case CSSPrimitiveValue::UnitType::Pixels:

+ case CSSPrimitiveValue::UnitType::UserUnits:

factor = 1;

break;

case CSSPrimitiveValue::UnitType::Exs: