third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp - Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp b/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

index ade7ec10472d24a5d78f0329af3ab220f9deaf7b..48bf31804c7f9985fd24c370b60395b75ad98e38 100644

--- a/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

@@ -49,7 +49,7 @@ void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGParsingErro

if (es.hadException()) {

parseError = ParsingAttributeFailedError;

- baseValue()->newValueSpecifiedUnits(LengthTypeNumber, 0);

+ baseValue()->newValueSpecifiedUnits(CSSPrimitiveValue::UnitType::Number, 0);

fs 2015/10/30 19:50:00 All of these explicit uses should probably be User

Stephen Chennney 2015/11/03 21:59:41 Yes. I think I got them.

} else if (m_negativeValuesMode == ForbidNegativeLengths && baseValue()->valueInSpecifiedUnits() < 0) {

parseError = NegativeValueForbiddenError;

}