third_party/WebKit/Source/core/css/CSSCalculationValue.cpp - Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp b/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

index dc4569851b93c4f0a7f486576e2ad8083dac6105..cbd4444304072edb21106eba0ec6d4df9991881f 100644

--- a/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

@@ -63,6 +63,7 @@ static CalculationCategory unitCategory(CSSPrimitiveValue::UnitType type)

case CSSPrimitiveValue::UnitType::Inches:

case CSSPrimitiveValue::UnitType::Points:

case CSSPrimitiveValue::UnitType::Picas:

+ case CSSPrimitiveValue::UnitType::UserUnits:

case CSSPrimitiveValue::UnitType::Rems:

case CSSPrimitiveValue::UnitType::Chs:

case CSSPrimitiveValue::UnitType::ViewportWidth:

@@ -101,6 +102,7 @@ static bool hasDoubleValue(CSSPrimitiveValue::UnitType type)

case CSSPrimitiveValue::UnitType::Inches:

case CSSPrimitiveValue::UnitType::Points:

case CSSPrimitiveValue::UnitType::Picas:

+ case CSSPrimitiveValue::UnitType::UserUnits:

case CSSPrimitiveValue::UnitType::Degrees:

case CSSPrimitiveValue::UnitType::Radians:

case CSSPrimitiveValue::UnitType::Gradians: