Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14215009: Changed cloud print private API to pass all page settings as single object. (Closed)

Created:
7 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Changed cloud print private API to pass all page settings as single object. Pass settings from connector setup page using "UserSettings" object that includes "connectNewPrinters" flag and list of "PrinterSettings". BUG=230187 R=gene Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194754

Patch Set 1 : #

Total comments: 2

Patch Set 2 : fixed warning and unittes #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -103 lines) Patch
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc View 1 2 2 chunks +21 lines, -8 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.h View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/cloud_print_private.json View 1 2 2 chunks +38 lines, -9 lines 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/common/service_messages.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M chrome/service/cloud_print/connector_settings.h View 1 2 3 4 chunks +13 lines, -12 lines 0 comments Download
M chrome/service/cloud_print/connector_settings.cc View 1 2 2 chunks +22 lines, -10 lines 0 comments Download
M chrome/service/cloud_print/connector_settings_unittest.cc View 1 2 4 chunks +16 lines, -13 lines 0 comments Download
M chrome/service/service_ipc_server.h View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/cloud_print_private/enable_chrome_connector/cloud_print_success_tests.js View 1 2 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 8 months ago (2013-04-14 00:58:03 UTC) #1
gene
lgtm nit: you should probably update issue description to include info about UserSettings passed. https://codereview.chromium.org/14215009/diff/27001/chrome/browser/resources/cloud_print_app/manifest.json ...
7 years, 8 months ago (2013-04-15 18:36:15 UTC) #2
Vitaly Buka (NO REVIEWS)
done https://codereview.chromium.org/14215009/diff/27001/chrome/browser/resources/cloud_print_app/manifest.json File chrome/browser/resources/cloud_print_app/manifest.json (right): https://codereview.chromium.org/14215009/diff/27001/chrome/browser/resources/cloud_print_app/manifest.json#newcode2 chrome/browser/resources/cloud_print_app/manifest.json:2: "key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDqOhnwk4+HXVfGyaNsAQdU/js1Na56diW08oF1MhZiwzSnJsEaeuMN9od9q9N4ZdK3o1xXOSARrYdE+syV7Dl31nf6qz3A6K+D5NHe6sSB9yvYlIiN37jdWdrfxxE0pRYEVYZNTe3bzq3NkcYJlOdt1UPcpJB+isXpAGUKUvt7EQIDAQAB", This file is unchanged. I had ...
7 years, 8 months ago (2013-04-15 18:42:09 UTC) #3
Vitaly Buka (NO REVIEWS)
7 years, 8 months ago (2013-04-15 19:00:02 UTC) #4
Cris Neckar
lgtm for ipc changes
7 years, 8 months ago (2013-04-15 19:09:19 UTC) #5
Vitaly Buka (NO REVIEWS)
Hi Antony, please review 'extensions' changes.
7 years, 8 months ago (2013-04-17 02:57:55 UTC) #6
asargent_no_longer_on_chrome
lgtm w/ one question https://codereview.chromium.org/14215009/diff/59001/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h File chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h (right): https://codereview.chromium.org/14215009/diff/59001/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h#newcode16 chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h:16: optional suggestion: remove this blank ...
7 years, 8 months ago (2013-04-17 19:05:04 UTC) #7
Vitaly Buka (NO REVIEWS)
also reverted "displayName" https://codereview.chromium.org/14215009/diff/59001/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h File chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h (right): https://codereview.chromium.org/14215009/diff/59001/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h#newcode16 chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h:16: On 2013/04/17 19:05:04, Antony Sargent wrote: ...
7 years, 8 months ago (2013-04-18 00:00:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14215009/76004
7 years, 8 months ago (2013-04-18 00:12:03 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 02:19:33 UTC) #10
Message was sent while issue was closed. 
Change committed as 194754

Powered by Google App Engine
This is Rietveld 408576698