chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc - Issue 14215009: Changed cloud print private API to pass all page settings as single object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

Issue 14215009: Changed cloud print private API to pass all page settings as single object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h ('k') | chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

diff --git a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

index 7c4343ed323c299fbcedbfaa800f95bed0f24308..a2529d6e6736615ec2d3f236fb6ba330eb313fd6 100644

--- a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

+++ b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

@@ -46,17 +46,17 @@ bool CloudPrintPrivateSetupConnectorFunction::RunImpl() {

params->user_email,

params->robot_email,

params->credentials,

- params->connect_new_printers,

- params->printer_blacklist);

+ params->user_settings);

} else {

if (!CloudPrintProxyServiceFactory::GetForProfile(profile_))

return false;

+ scoped_ptr<base::DictionaryValue> user_setings(

+ params->user_settings.ToValue());

CloudPrintProxyServiceFactory::GetForProfile(profile_)->

EnableForUserWithRobot(params->credentials,

params->robot_email,

params->user_email,

- params->connect_new_printers,

- params->printer_blacklist);

+ *user_setings);

}

SendResponse(true);

return true;