Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/aura/window.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/discardable_shared_memory_heap.cc ('K') | « gpu/command_buffer/service/texture_definition.cc ('k') | ui/events/blink/blink_event_util.cc » ('j') | ui/gl/gl_image_memory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window.cc
diff --git a/ui/aura/window.cc b/ui/aura/window.cc
index c67c0a8ac4e84adf4bba478fe827e1a6ae766160..79ef0ce50c4712b545347cf645304fcd9fbbb1f3 100644
--- a/ui/aura/window.cc
+++ b/ui/aura/window.cc
@@ -223,7 +223,7 @@ void Window::Show() {
// It is not allowed that a window is visible but the layers alpha is fully
// transparent since the window would still be considered to be active but
// could not be seen.
- DCHECK_IMPLIES(visible_, layer()->GetTargetOpacity() > 0.0f);
+ DCHECK(!visible_ || layer()->GetTargetOpacity() > 0.0f);
SetVisible(true);
}
« content/common/discardable_shared_memory_heap.cc ('K') | « gpu/command_buffer/service/texture_definition.cc ('k') | ui/events/blink/blink_event_util.cc » ('j') | ui/gl/gl_image_memory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698