Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gl/gl_image_memory.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/discardable_shared_memory_heap.cc ('K') | « ui/gl/gl_fence_egl.cc ('k') | ui/views/touchui/touch_selection_menu_runner_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_image_memory.cc
diff --git a/ui/gl/gl_image_memory.cc b/ui/gl/gl_image_memory.cc
index ad1e6b944b645179923b5a6b93a79525ceb0c783..9ed470f52506a055f0eef56e4352b8db30b2b287 100644
--- a/ui/gl/gl_image_memory.cc
+++ b/ui/gl/gl_image_memory.cc
@@ -258,8 +258,8 @@ bool GLImageMemory::Initialize(const unsigned char* memory,
DCHECK(memory);
DCHECK(!memory_);
- DCHECK_IMPLIES(IsCompressedFormat(format), size_.width() % 4 == 0);
- DCHECK_IMPLIES(IsCompressedFormat(format), size_.height() % 4 == 0);
+ DCHECK(!IsCompressedFormat(format) || (size_.width() % 4 == 0));
Nico 2015/10/26 17:45:27 nit: parens on rhs not needed (also in the line be
vmpstr 2015/10/26 18:10:08 Done.
+ DCHECK(!IsCompressedFormat(format) || (size_.height() % 4 == 0));
memory_ = memory;
format_ = format;
return true;
« content/common/discardable_shared_memory_heap.cc ('K') | « ui/gl/gl_fence_egl.cc ('k') | ui/views/touchui/touch_selection_menu_runner_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698