Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/test/test_web_contents.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/discardable_shared_memory_heap.cc ('K') | « content/test/test_render_frame_host.cc ('k') | content/test/web_contents_observer_sanity_checker.cc » ('j') | ui/gl/gl_image_memory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_web_contents.cc
diff --git a/content/test/test_web_contents.cc b/content/test/test_web_contents.cc
index b8d0092b232862be884a861df6da21182427891e..dd12be8878878db72528bf8d306f541d7ca9f2d8 100644
--- a/content/test/test_web_contents.cc
+++ b/content/test/test_web_contents.cc
@@ -226,9 +226,9 @@ void TestWebContents::CommitPendingNavigation() {
TestRenderFrameHost* rfh = GetPendingMainFrame();
if (!rfh)
rfh = old_rfh;
- CHECK_IMPLIES(browser_side_navigation, rfh->is_loading());
- CHECK_IMPLIES(browser_side_navigation,
- !rfh->frame_tree_node()->navigation_request());
+ CHECK(!browser_side_navigation || rfh->is_loading());
+ CHECK(!browser_side_navigation ||
+ !rfh->frame_tree_node()->navigation_request());
int page_id = entry->GetPageID();
if (page_id == -1) {
« content/common/discardable_shared_memory_heap.cc ('K') | « content/test/test_render_frame_host.cc ('k') | content/test/web_contents_observer_sanity_checker.cc » ('j') | ui/gl/gl_image_memory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698