content/common/gpu/media/vp9_decoder.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/vp9_decoder.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/vp9_decoder.cc

diff --git a/content/common/gpu/media/vp9_decoder.cc b/content/common/gpu/media/vp9_decoder.cc

index 7c25832cdc12c89cd6895f6c56744cc620c3d0da..c1adc84bbdeb2561c3523588e4d61f8825b07079 100644

--- a/content/common/gpu/media/vp9_decoder.cc

+++ b/content/common/gpu/media/vp9_decoder.cc

@@ -138,8 +138,7 @@ VP9Decoder::DecodeResult VP9Decoder::Decode() {

void VP9Decoder::RefreshReferenceFrames(const scoped_refptr<VP9Picture>& pic) {

for (size_t i = 0; i < media::kVp9NumRefFrames; ++i) {

- DCHECK_IMPLIES(pic->frame_hdr->IsKeyframe(),

- pic->frame_hdr->RefreshFlag(i));

+ DCHECK(!pic->frame_hdr->IsKeyframe() || pic->frame_hdr->RefreshFlag(i));

if (pic->frame_hdr->RefreshFlag(i))

ref_frames_[i] = pic;

}