ui/gl/gl_fence_egl.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_fence_egl.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gl/gl_fence_egl.cc

diff --git a/ui/gl/gl_fence_egl.cc b/ui/gl/gl_fence_egl.cc

index 641b8c2e3fc6772cd467975b5031ee7bc5c6a042..ce6583d6325b2a739c7e8bbead139e0a2ea78267 100644

--- a/ui/gl/gl_fence_egl.cc

+++ b/ui/gl/gl_fence_egl.cc

@@ -44,8 +44,7 @@ void GLFenceEGL::ClientWait() {

EGLint flags = 0;

EGLTimeKHR time = EGL_FOREVER_KHR;

EGLint result = eglClientWaitSyncKHR(display_, sync_, flags, time);

- DCHECK_IMPLIES(!g_ignore_egl_sync_failures,

- EGL_TIMEOUT_EXPIRED_KHR != result);

+ DCHECK(g_ignore_egl_sync_failures || EGL_TIMEOUT_EXPIRED_KHR != result);

if (result == EGL_FALSE) {

LOG(ERROR) << "Failed to wait for EGLSync. error:"

<< ui::GetLastEGLErrorString();

« no previous file with comments | « ui/events/blink/blink_event_util.cc ('k') | ui/gl/gl_image_memory.cc » ('j') | no next file with comments »