ui/events/blink/blink_event_util.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/blink/blink_event_util.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/blink/blink_event_util.cc

diff --git a/ui/events/blink/blink_event_util.cc b/ui/events/blink/blink_event_util.cc

index 4b19b3e9ab15e9bf3841fe5aea1eb2b71de2ef61..659adf3541bdfd72a93e5d46b0f056ee9391f96f 100644

--- a/ui/events/blink/blink_event_util.cc

+++ b/ui/events/blink/blink_event_util.cc

@@ -123,7 +123,7 @@ WebTouchPoint CreateWebTouchPoint(const MotionEvent& event,

float minor_radius = event.GetTouchMinor(pointer_index) / 2.f;

DCHECK_LE(minor_radius, major_radius);

- DCHECK_IMPLIES(major_radius, minor_radius);

+ DCHECK(!major_radius || minor_radius);

float orientation_deg = event.GetOrientation(pointer_index) * 180.f / M_PI;

DCHECK_GE(major_radius, 0);

« no previous file with comments | « ui/aura/window.cc ('k') | ui/gl/gl_fence_egl.cc » ('j') | no next file with comments »