ui/aura/window.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/window.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/window.cc

diff --git a/ui/aura/window.cc b/ui/aura/window.cc

index c67c0a8ac4e84adf4bba478fe827e1a6ae766160..79ef0ce50c4712b545347cf645304fcd9fbbb1f3 100644

--- a/ui/aura/window.cc

+++ b/ui/aura/window.cc

@@ -223,7 +223,7 @@ void Window::Show() {

// It is not allowed that a window is visible but the layers alpha is fully

// transparent since the window would still be considered to be active but

// could not be seen.

- DCHECK_IMPLIES(visible_, layer()->GetTargetOpacity() > 0.0f);

+ DCHECK(!visible_ || layer()->GetTargetOpacity() > 0.0f);

SetVisible(true);

}