content/common/gpu/client/gl_helper_scaling.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gl_helper_scaling.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/client/gl_helper_scaling.cc

diff --git a/content/common/gpu/client/gl_helper_scaling.cc b/content/common/gpu/client/gl_helper_scaling.cc

index 7b7338dc07e1ec5db68e7b31ec664a6588f47c57..49cab4920765c97a4ab7bc76969109041c4ba030 100644

--- a/content/common/gpu/client/gl_helper_scaling.cc

+++ b/content/common/gpu/client/gl_helper_scaling.cc

@@ -870,8 +870,7 @@ void ShaderProgram::Setup(const GLchar* vertex_shader_text,

// The only reason fetching these attribute locations should fail is

// if the context was spontaneously lost (i.e., because the GPU

// process crashed, perhaps deliberately for testing).

- DCHECK_IMPLIES(!Initialized(),

- gl_->GetGraphicsResetStatusKHR() != GL_NO_ERROR);

+ DCHECK(Initialized() || gl_->GetGraphicsResetStatusKHR() != GL_NO_ERROR);

}

void ShaderProgram::UseProgram(const gfx::Size& src_size,