Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1877)

Unified Diff: content/common/discardable_shared_memory_heap.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/common/gpu/client/gl_helper_scaling.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/discardable_shared_memory_heap.cc
diff --git a/content/common/discardable_shared_memory_heap.cc b/content/common/discardable_shared_memory_heap.cc
index bf124f75605c0f9e3b8798713fd2dbc97ac259d0..61f05d3ecd35dccb59ea9c342cf662bb3698beb4 100644
--- a/content/common/discardable_shared_memory_heap.cc
+++ b/content/common/discardable_shared_memory_heap.cc
@@ -176,8 +176,8 @@ DiscardableSharedMemoryHeap::Split(Span* span, size_t blocks) {
scoped_ptr<Span> leftover(new Span(
span->shared_memory_, span->start_ + blocks, span->length_ - blocks));
- DCHECK_IMPLIES(leftover->length_ > 1,
- spans_.find(leftover->start_) == spans_.end());
+ DCHECK(leftover->length_ == 1 ||
+ spans_.find(leftover->start_) == spans_.end());
RegisterSpan(leftover.get());
spans_[span->start_ + blocks - 1] = span;
span->length_ = blocks;
@@ -281,7 +281,7 @@ DiscardableSharedMemoryHeap::Carve(Span* span, size_t blocks) {
scoped_ptr<Span> leftover(
new Span(serving->shared_memory_, serving->start_ + blocks, extra));
leftover->set_is_locked(false);
- DCHECK_IMPLIES(extra > 1, spans_.find(leftover->start_) == spans_.end());
+ DCHECK(extra == 1 || spans_.find(leftover->start_) == spans_.end());
RegisterSpan(leftover.get());
// No need to coalesce as the previous span of |leftover| was just split
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/common/gpu/client/gl_helper_scaling.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698