cc/input/top_controls_manager.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/input/top_controls_manager.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/input/top_controls_manager.cc

diff --git a/cc/input/top_controls_manager.cc b/cc/input/top_controls_manager.cc

index 1a961b50e9393697598bf83738dbe3684c56d1e4..5fe126726af170296cb3f0463ada0ad034cc1366 100644

--- a/cc/input/top_controls_manager.cc

+++ b/cc/input/top_controls_manager.cc

@@ -176,8 +176,8 @@ void TopControlsManager::ResetAnimations() {

void TopControlsManager::SetupAnimation(AnimationDirection direction) {

DCHECK_NE(NO_ANIMATION, direction);

- DCHECK_IMPLIES(direction == HIDING_CONTROLS, TopControlsShownRatio() > 0.f);

- DCHECK_IMPLIES(direction == SHOWING_CONTROLS, TopControlsShownRatio() < 1.f);

+ DCHECK(direction != HIDING_CONTROLS || TopControlsShownRatio() > 0.f);

+ DCHECK(direction != SHOWING_CONTROLS || TopControlsShownRatio() < 1.f);

if (top_controls_animation_ && animation_direction_ == direction)

return;

« no previous file with comments | « cc/animation/animation_player.cc ('k') | cc/layers/picture_layer.cc » ('j') | no next file with comments »