cc/animation/animation_player.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/animation_player.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/animation/animation_player.cc

diff --git a/cc/animation/animation_player.cc b/cc/animation/animation_player.cc

index 0bec9265426789d5dd537e56913198e88d4624cb..0c380118987882b29692f850b4b8c26c8e769fcf 100644

--- a/cc/animation/animation_player.cc

+++ b/cc/animation/animation_player.cc

@@ -119,9 +119,8 @@ void AnimationPlayer::UnbindElementAnimations() {

}

void AnimationPlayer::AddAnimation(scoped_ptr<Animation> animation) {

- DCHECK_IMPLIES(

- animation->target_property() == Animation::SCROLL_OFFSET,

- animation_host_ && animation_host_->SupportsScrollAnimations());

+ DCHECK(animation->target_property() != Animation::SCROLL_OFFSET ||

+ (animation_host_ && animation_host_->SupportsScrollAnimations()));

if (element_animations_) {

element_animations_->layer_animation_controller()->AddAnimation(

« no previous file with comments | « base/trace_event/trace_log.cc ('k') | cc/input/top_controls_manager.cc » ('j') | no next file with comments »