base/trace_event/trace_log.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_log.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_log.cc

diff --git a/base/trace_event/trace_log.cc b/base/trace_event/trace_log.cc

index 3987f33cd277ff4e92932534c05848adbc166362..d5a02dd8a010a7c147cd67420433d04ab5044c7a 100644

--- a/base/trace_event/trace_log.cc

+++ b/base/trace_event/trace_log.cc

@@ -883,7 +883,7 @@ void TraceLog::FlushInternal(const TraceLog::OutputCallback& cb,

flush_task_runner_ = ThreadTaskRunnerHandle::IsSet()

? ThreadTaskRunnerHandle::Get()

: nullptr;

- DCHECK_IMPLIES(thread_message_loops_.size(), flush_task_runner_);

+ DCHECK(!thread_message_loops_.size() || flush_task_runner_);

flush_output_callback_ = cb;

if (thread_shared_chunk_) {

« no previous file with comments | « base/trace_event/memory_dump_manager.cc ('k') | cc/animation/animation_player.cc » ('j') | no next file with comments »