Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1421483004: Revert of GetOwnPropertyDescriptor: API-style accessors can throw, check for that. (Closed)

Created:
5 years, 2 months ago by Michael Hablich
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Toon Verwaest
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of GetOwnPropertyDescriptor: API-style accessors can throw, check for that. (patchset #1 id:1 of https://codereview.chromium.org/1412823003/ ) Reason for revert: Breaks test if rolled into Chromium: http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%281%29&number=60441 Original issue's description: > GetOwnPropertyDescriptor: API-style accessors can throw, check for that. > > Committed: https://crrev.com/cbda86196b0b52694f50982ae3f1ac8e72056e6d > Cr-Commit-Position: refs/heads/master@{#31522} TBR=cbruni@chromium.org,jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a0f5d4995c9edc99b97d6b3bc3e4081891eb7f91 Cr-Commit-Position: refs/heads/master@{#31532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/objects.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Hablich
Created Revert of GetOwnPropertyDescriptor: API-style accessors can throw, check for that.
5 years, 2 months ago (2015-10-23 19:19:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421483004/1
5 years, 2 months ago (2015-10-23 19:19:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 19:19:48 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 19:20:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0f5d4995c9edc99b97d6b3bc3e4081891eb7f91
Cr-Commit-Position: refs/heads/master@{#31532}

Powered by Google App Engine
This is Rietveld 408576698