Fix mac after https://codereview.chromium.org/1419623003/

Fix mac after https://codereview.chromium.org/1419623003/

L"" and wstring are a bit of a mess cross-platform, so just store the
type name as UTF8 instead.

R=mark@chromium.org
BUG=crashpad:21, crashpad:52
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/fe49473b3d88f00c8796c063b7362e27d58567e0

[scottmg, 2015-10-21 18:25:10]

Description was changed from

==========
Fix mac after https://codereview.chromium.org/1419623003/

R=mark@chromium.org
BUG=crashpad:21, crashpad:52
==========

to

==========
Fix mac after https://codereview.chromium.org/1419623003/

L"" and wstring are a bit of a mess cross-platform, so just store
the type name as UTF8 instead.

R=mark@chromium.org
BUG=crashpad:21, crashpad:52
==========

[Mark Mentovai, 2015-10-21 18:31:28]

LGTM but consider the alternative.

https://codereview.chromium.org/1421473005/diff/40001/minidump/minidump_handl...
File minidump/minidump_handle_writer_test.cc (left):

https://codereview.chromium.org/1421473005/diff/40001/minidump/minidump_handl...
minidump/minidump_handle_writer_test.cc:81: handle_snapshot.type_name =
L"Something";
It looks like this was the only offending use. An alternative would have been to
just write UTF8ToUTF16("Something") here.

https://codereview.chromium.org/1421473005/diff/40001/snapshot/win/process_sn...
File snapshot/win/process_snapshot_win.cc (right):

https://codereview.chromium.org/1421473005/diff/40001/snapshot/win/process_sn...
snapshot/win/process_snapshot_win.cc:217: // carefully done if the object name
is added.
As long as the only consumer is the minidump writer, it ought to be OK because
that will undo the transformation with UTF8ToUTF16().

[scottmg, 2015-10-21 18:35:44]

https://codereview.chromium.org/1421473005/diff/40001/minidump/minidump_handl...
File minidump/minidump_handle_writer_test.cc (left):

https://codereview.chromium.org/1421473005/diff/40001/minidump/minidump_handl...
minidump/minidump_handle_writer_test.cc:81: handle_snapshot.type_name =
L"Something";
On 2015/10/21 18:31:28, Mark Mentovai wrote:
> It looks like this was the only offending use. An alternative would have been
to
> just write UTF8ToUTF16("Something") here.

Yeah, that's what I tried at first, but the SetUTF16 and test code was a mess
too.

[scottmg, 2015-10-21 18:39:59]

Committed patchset #3 (id:40001) manually as
fe49473b3d88f00c8796c063b7362e27d58567e0 (presubmit successful).