minidump/minidump_handle_writer.cc - Issue 1421473005: Fix mac after https://codereview.chromium.org/1419623003/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_handle_writer.cc

Issue 1421473005: Fix mac after https://codereview.chromium.org/1419623003/ (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_handle_writer.cc

diff --git a/minidump/minidump_handle_writer.cc b/minidump/minidump_handle_writer.cc

index 235d71b0db995ffec7db6e1f3314015084f4ad22..73c518c193f63ab18e80804a9fc8e40e207ce6a3 100644

--- a/minidump/minidump_handle_writer.cc

+++ b/minidump/minidump_handle_writer.cc

@@ -50,7 +50,7 @@ void MinidumpHandleDataWriter::InitializeFromSnapshot(

// TODO(scottmg): There is often a number of repeated type names here, the

// strings ought to be pooled.

strings_.push_back(new internal::MinidumpUTF16StringWriter());

- strings_.back()->SetUTF16(handle_snapshot.type_name);

+ strings_.back()->SetUTF8(handle_snapshot.type_name);

strings_.back()->RegisterRVA(&descriptor.TypeNameRva);

}

« no previous file with comments | « no previous file | minidump/minidump_handle_writer_test.cc » ('j') | minidump/minidump_handle_writer_test.cc » ('J')