chrome/renderer/resources/plugins/plugin_poster.html - Issue 1421423005: [css-flexbox] Fix min-size: auto for a non-auto flex basis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/plugins/plugin_poster.html

Issue 1421423005: [css-flexbox] Fix min-size: auto for a non-auto flex basis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: had to update some plugin placeholder files as well Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/plugins/plugin_placeholders.css ('K') | « chrome/renderer/resources/plugins/plugin_placeholders.css ('k') | third_party/WebKit/LayoutTests/css3/flexbox/min-size-auto.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/plugins/plugin_poster.html

diff --git a/chrome/renderer/resources/plugins/plugin_poster.html b/chrome/renderer/resources/plugins/plugin_poster.html

index 962e9bcc7d7986fec461cae76fc7413a8223955f..b9b1de7a791b7e34ab4cd147c17d3a40d8119d7b 100644

--- a/chrome/renderer/resources/plugins/plugin_poster.html

+++ b/chrome/renderer/resources/plugins/plugin_poster.html

@@ -37,6 +37,8 @@

opacity: 0.8;

max-height: 100%;

max-width: 100%;

+ min-width: 0;

+ min-height: 0;

}

#plugin-icon:hover {

@@ -44,6 +46,8 @@

}

#poster {

+ min-width: 0;

tommycli 2015/10/28 21:02:01 Probably not needed.

cbiesinger 2015/10/28 21:13:14 Yeah, not needed for the tests. Removed.

+ min-height: 0;

height: 100%;

object-fit: contain;

width: 100%;

@@ -58,6 +62,8 @@

left: 0px;

max-height: 100%;

max-width: 100%;

+ min-height: 0;

tommycli 2015/10/28 21:02:01 Probably not needed also if plugin-icon itself is

cbiesinger 2015/10/28 21:13:14 Removed.

+ min-width: 0;

position: absolute;

top: 0px;

width: 100%;