chrome/renderer/resources/plugins/plugin_poster.html - Issue 1421423005: [css-flexbox] Fix min-size: auto for a non-auto flex basis

Side by Side Diff: chrome/renderer/resources/plugins/plugin_poster.html

Issue 1421423005: [css-flexbox] Fix min-size: auto for a non-auto flex basis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: had to update some plugin placeholder files as well Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/resources/plugins/plugin_placeholders.css ('K') | « chrome/renderer/resources/plugins/plugin_placeholders.css ('k') | third_party/WebKit/LayoutTests/css3/flexbox/min-size-auto.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <meta name="viewport" content="width=device-width, user-scalable=no">	5 <meta name="viewport" content="width=device-width, user-scalable=no">

6 <script>	6 <script>

7 window.onload = function() {	7 window.onload = function() {

8 if (plugin.didFinishLoading)	8 if (plugin.didFinishLoading)

9 plugin.didFinishLoading();	9 plugin.didFinishLoading();

10 };	10 };

(...skipping 19 matching lines...) Expand all Loading...
30 position: absolute;	30 position: absolute;

31 top: 0px;	31 top: 0px;

32 width: 100%;	32 width: 100%;

33 z-index: 2;	33 z-index: 2;

34 }	34 }

35	35

36 #plugin-icon {	36 #plugin-icon {

37 opacity: 0.8;	37 opacity: 0.8;

38 max-height: 100%;	38 max-height: 100%;

39 max-width: 100%;	39 max-width: 100%;

	40 min-width: 0;

	41 min-height: 0;

40 }	42 }

41	43

42 #plugin-icon:hover {	44 #plugin-icon:hover {

43 opacity: 0.95;	45 opacity: 0.95;

44 }	46 }

45	47

46 #poster {	48 #poster {

	49 min-width: 0;
	tommycli 2015/10/28 21:02:01 Probably not needed. Probably not needed. cbiesinger 2015/10/28 21:13:14 Yeah, not needed for the tests. Removed. Show quoted text On 2015/10/28 21:02:01, tommycli wrote: > Probably not needed. Yeah, not needed for the tests. Removed.
	50 min-height: 0;

47 height: 100%;	51 height: 100%;

48 object-fit: contain;	52 object-fit: contain;

49 width: 100%;	53 width: 100%;

50 z-index: 1;	54 z-index: 1;

51 }	55 }

52	56

53 #inner-container {	57 #inner-container {

54 align-items: center;	58 align-items: center;

55 display: flex;	59 display: flex;

56 height: 100%;	60 height: 100%;

57 justify-content: center;	61 justify-content: center;

58 left: 0px;	62 left: 0px;

59 max-height: 100%;	63 max-height: 100%;

60 max-width: 100%;	64 max-width: 100%;

	65 min-height: 0;
	tommycli 2015/10/28 21:02:01 Probably not needed also if plugin-icon itself is Probably not needed also if plugin-icon itself is squashed small right? cbiesinger 2015/10/28 21:13:14 Removed. Show quoted text On 2015/10/28 21:02:01, tommycli wrote: > Probably not needed also if plugin-icon itself is squashed small right? Removed.
	66 min-width: 0;

61 position: absolute;	67 position: absolute;

62 top: 0px;	68 top: 0px;

63 width: 100%;	69 width: 100%;

64 z-index: 2;	70 z-index: 2;

65 }	71 }

66 </style>	72 </style>

67 <base i18n-values="href:baseurl">	73 <base i18n-values="href:baseurl">

68 </head>	74 </head>

69	75

70 <body>	76 <body>

(...skipping 24 matching lines...) Expand all Loading...
95 if (plugin.didFinishIconRepositionForTesting) {	101 if (plugin.didFinishIconRepositionForTesting) {

96 // Defer until reflow complete.	102 // Defer until reflow complete.

97 window.setTimeout(function() {	103 window.setTimeout(function() {

98 plugin.didFinishIconRepositionForTesting();	104 plugin.didFinishIconRepositionForTesting();

99 });	105 });

100 }	106 }

101 };	107 };

102 </script>	108 </script>

103 </body>	109 </body>

104 </html>	110 </html>

OLD	NEW