Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 1421293006: Mac: Use GpuMemoryBuffers by default (Closed)

Created:
5 years, 1 month ago by ccameron
Modified:
5 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, ericrk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Use GpuMemoryBuffers by default Keep the feature disabled by default when GPU raster is enabled, as the two features are incompatible. BUG=533677 Committed: https://crrev.com/532a123352590fe939e3266ea51cc96e2559cefe Cr-Commit-Position: refs/heads/master@{#358411} Committed: https://crrev.com/a956c997fd06f9e1798b1d81d99a7eb1f23bb0b1 Cr-Commit-Position: refs/heads/master@{#358800}

Patch Set 1 #

Patch Set 2 : Disable when native GMBs are disabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -25 lines) Patch
M content/browser/gpu/browser_gpu_memory_buffer_manager.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 3 chunks +26 lines, -23 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 2 chunks +25 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (9 generated)
ccameron
Adding avi@ as content owner, adding ericrk@ as FYI.
5 years, 1 month ago (2015-11-03 21:36:59 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 1 month ago (2015-11-04 00:50:59 UTC) #3
ccameron
Thanks!
5 years, 1 month ago (2015-11-04 19:54:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421293006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421293006/1
5 years, 1 month ago (2015-11-04 19:56:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/136075)
5 years, 1 month ago (2015-11-04 21:30:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421293006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421293006/1
5 years, 1 month ago (2015-11-06 20:30:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 21:40:59 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/532a123352590fe939e3266ea51cc96e2559cefe Cr-Commit-Position: refs/heads/master@{#358411}
5 years, 1 month ago (2015-11-06 21:42:10 UTC) #12
ccameron
On 2015/11/06 21:42:10, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 1 month ago (2015-11-10 02:52:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421293006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421293006/60001
5 years, 1 month ago (2015-11-10 07:08:43 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 1 month ago (2015-11-10 07:13:36 UTC) #20
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 07:14:47 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a956c997fd06f9e1798b1d81d99a7eb1f23bb0b1
Cr-Commit-Position: refs/heads/master@{#358800}

Powered by Google App Engine
This is Rietveld 408576698