Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1165823003:
Re-land: content: Enable native GpuMemoryBuffers by default on MacOSX. (Closed)
DescriptionRe-land: content: Enable native GpuMemoryBuffers by default on MacOSX.
This eliminates the need for texture uploads to initialize
tile textures on MacOSX.
BUG=486922
Committed: https://crrev.com/eea3079462718502b0ccb2d7ebe8faffcfb3a687
Cr-Commit-Position: refs/heads/master@{#342287}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : cleanup #Patch Set 4 : lost context fix #Patch Set 5 : rebase #
Total comments: 1
Patch Set 6 : rebase #Patch Set 7 : make sure native buffers are disabled when using mesa #
Messages
Total messages: 47 (17 generated)
The CQ bit was checked by reveman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165823003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
reveman@chromium.org changed reviewers: + avi@chromium.org, ccameron@chromium.org
I think this is ready to land. Please take a look.
lgtm!
lgtm https://codereview.chromium.org/1165823003/diff/80001/content/public/common/c... File content/public/common/content_switches.cc (right): https://codereview.chromium.org/1165823003/diff/80001/content/public/common/c... content/public/common/content_switches.cc:200: "disable-native-gpu-memory-buffers"; Can we soon get rid of both? :)
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165823003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
reveman@chromium.org changed reviewers: + piman@chromium.org
fyi, this is currently blocked on https://codereview.chromium.org/1189943002
The CQ bit was checked by reveman@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/1165823003/#ps100001 (title: "rebase")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165823003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by reveman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165823003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2015/06/27 at 16:50:02, commit-bot wrote: > Dry run: This issue passed the CQ dry run. Looks like this is finally ready to land. Let's give it a try!
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165823003/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/ab11fd094eb5eb8913a87b9f12497cab0725c73a Cr-Commit-Position: refs/heads/master@{#336502}
Message was sent while issue was closed.
On 2015/06/27 at 22:01:08, commit-bot wrote: > Patchset 6 (id:??) landed as https://crrev.com/ab11fd094eb5eb8913a87b9f12497cab0725c73a > Cr-Commit-Position: refs/heads/master@{#336502} I think this change may have caused all mac layouttests to fail, see: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_10/... http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...
Message was sent while issue was closed.
On 2015/06/28 at 03:08:37, pdr wrote: > On 2015/06/27 at 22:01:08, commit-bot wrote: > > Patchset 6 (id:??) landed as https://crrev.com/ab11fd094eb5eb8913a87b9f12497cab0725c73a > > Cr-Commit-Position: refs/heads/master@{#336502} > > I think this change may have caused all mac layouttests to fail, see: > https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_10/... > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas... I confirmed reverting this patch fixes the issue. I'm going to roll this out for now.
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1219603002/ by pdr@chromium.org. The reason for reverting is: This change may have caused many mac layouttests to fail, see: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_10/... http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas... Reverting locally fixed this issue. BUG=486922.
This was failing because layout tests use Mesa GL and native buffers are not supported in that case. Re-landing after adding a check that prevents native buffers from being used with Mesa GL.
The CQ bit was checked by reveman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/1165823003/#ps120001 (title: "make sure native buffers are disabled when using mesa")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165823003/120001
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/aff70f7fcd9be4d503c97f93f5fae31a43ec3e23 Cr-Commit-Position: refs/heads/master@{#337657}
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1232083007/ by erikchen@chromium.org. The reason for reverting is: Windows get stuck displaying all white for content area. https://code.google.com/p/chromium/issues/detail?id=509917.
The CQ bit was checked by reveman@chromium.org
fyi, I'll re-land this now that the issue has been fixed and worker context based one-copy has landed.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165823003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1165823003/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165823003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1165823003/120001
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/eea3079462718502b0ccb2d7ebe8faffcfb3a687 Cr-Commit-Position: refs/heads/master@{#342287} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
