Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1421293005: Move new Startup.FirstWebContents.* stats to Startup.FirstWebContents.*2. (Closed)

Created:
5 years, 1 month ago by gab
Modified:
5 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ab2_moar_betta_metrics
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move new Startup.FirstWebContents.* stats to Startup.FirstWebContents.*2. Keep the old version of the stats around for a milestone as a comparison basis. BUG=525209 TBR=pkasting@chromium.org (for side-effects in c/b/ui browser_test) Committed: https://crrev.com/70c396848a1d592b6e5fcb9b8c6b588b7a1149c9 Cr-Commit-Position: refs/heads/master@{#356896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -23 lines) Patch
M chrome/browser/metrics/first_web_contents_profiler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/metrics/first_web_contents_profiler.cc View 4 chunks +25 lines, -11 lines 0 comments Download
M chrome/browser/ui/profile_error_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/metrics/proto/profiler_event.proto View 1 chunk +1 line, -1 line 0 comments Download
M components/startup_metric_utils/startup_metric_utils.h View 1 chunk +12 lines, -2 lines 0 comments Download
M components/startup_metric_utils/startup_metric_utils.cc View 2 chunks +28 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +30 lines, -2 lines 0 comments Download
M tools/perf/metrics/startup_metric.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/blank_page.py View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
gab
Robert, as discussed, PTAL. Thanks, Gab
5 years, 1 month ago (2015-10-28 21:09:46 UTC) #2
rkaplow
lgtm thanks!
5 years, 1 month ago (2015-10-28 21:41:20 UTC) #3
gab
TBR pkasting for side-effects in a c/b/ui/ browser_test +sullivan for tools/perf side-effects (and as FYI ...
5 years, 1 month ago (2015-10-29 11:33:47 UTC) #5
sullivan
lgtm
5 years, 1 month ago (2015-10-29 17:06:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421293005/1
5 years, 1 month ago (2015-10-29 17:08:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 18:37:47 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 18:38:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70c396848a1d592b6e5fcb9b8c6b588b7a1149c9
Cr-Commit-Position: refs/heads/master@{#356896}

Powered by Google App Engine
This is Rietveld 408576698