Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1421193006: Revert of Revert "Revert of [es6] Implement destructuring binding in try/catch" (Closed)

Created:
5 years, 1 month ago by Michael Achenbach
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert "Revert of [es6] Implement destructuring binding in try/catch" (patchset #2 id:20001 of https://codereview.chromium.org/1411323008/ ) Reason for revert: [Sheriff] Breaks a layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2750 Please request rebase upstream first if intended. Original issue's description: > Revert "Revert of [es6] Implement destructuring binding in try/catch" > > Reland try/catch destructuring with a fix for the MemorySanitizer failure: > initialization_pos needs to be initialized in the DeclarationDescriptor. > > This is a one line fix to http://crrev.com/a316db995e6e4253664920652ed4e5a38b2caeba > > BUG=v8:811 > LOG=y > > Committed: https://crrev.com/80a1e004f4ef619b54a2d87bf2108719a8411860 > Cr-Commit-Position: refs/heads/master@{#31834} TBR=littledan@chromium.org,rossberg@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:811 Committed: https://crrev.com/35a60c211e955f6c1b76a268ebb9317e6a6574af Cr-Commit-Position: refs/heads/master@{#31840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -132 lines) Patch
M src/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.cc View 3 chunks +8 lines, -68 lines 0 comments Download
M src/preparser.cc View 1 chunk +1 line, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D test/message/try-catch-lexical-conflict.js View 1 chunk +0 lines, -11 lines 0 comments Download
D test/message/try-catch-lexical-conflict.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/try-catch-variable-conflict.js View 1 chunk +0 lines, -10 lines 0 comments Download
D test/message/try-catch-variable-conflict.out View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Revert "Revert of [es6] Implement destructuring binding in try/catch"
5 years, 1 month ago (2015-11-05 19:28:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421193006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421193006/1
5 years, 1 month ago (2015-11-05 19:28:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 19:28:44 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 19:29:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35a60c211e955f6c1b76a268ebb9317e6a6574af
Cr-Commit-Position: refs/heads/master@{#31840}

Powered by Google App Engine
This is Rietveld 408576698