Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1411323008: Revert "Revert of [es6] Implement destructuring binding in try/catch" (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
Dan Ehrenberg, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Revert of [es6] Implement destructuring binding in try/catch" Reland try/catch destructuring with a fix for the MemorySanitizer failure: initialization_pos needs to be initialized in the DeclarationDescriptor. This is a one line fix to http://crrev.com/a316db995e6e4253664920652ed4e5a38b2caeba BUG=v8:811 LOG=y Committed: https://crrev.com/80a1e004f4ef619b54a2d87bf2108719a8411860 Cr-Commit-Position: refs/heads/master@{#31834}

Patch Set 1 #

Patch Set 2 : initialization_pos fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -10 lines) Patch
M src/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 1 3 chunks +67 lines, -7 lines 0 comments Download
M src/preparser.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + test/message/try-catch-lexical-conflict.js View 1 chunk +5 lines, -1 line 0 comments Download
A test/message/try-catch-lexical-conflict.out View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/message/try-catch-variable-conflict.js View 1 chunk +4 lines, -1 line 0 comments Download
A test/message/try-catch-variable-conflict.out View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
adamk
Dan, could you review this re-land? Just a one line fix to the initial CL ...
5 years, 1 month ago (2015-11-04 20:16:05 UTC) #3
rossberg
lgtm
5 years, 1 month ago (2015-11-05 08:40:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411323008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411323008/20001
5 years, 1 month ago (2015-11-05 16:34:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-05 17:27:54 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/80a1e004f4ef619b54a2d87bf2108719a8411860 Cr-Commit-Position: refs/heads/master@{#31834}
5 years, 1 month ago (2015-11-05 17:28:04 UTC) #8
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1421193006/ by machenbach@chromium.org. ...
5 years, 1 month ago (2015-11-05 19:28:23 UTC) #9
adamk
5 years, 1 month ago (2015-11-05 19:40:09 UTC) #10
Message was sent while issue was closed.
On 2015/11/05 19:28:23, Michael Achenbach wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1421193006/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Breaks a layout test:
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...
> 
> Please request rebase upstream first if intended..

Marked as failing upstream in https://codereview.chromium.org/1427353003

Powered by Google App Engine
This is Rietveld 408576698