Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421163005: Implemented the ctz Turbo Fan operator for x64. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implemented the ctz Turbo Fan operator for x64. Ctz is implemented as an optional operator at the moment, which is only implemented by x64 at the moment. R=titzer@chromium.org Committed: https://crrev.com/a594ff73a989c48e23da6f3f06bf816b7bdc75ab Cr-Commit-Position: refs/heads/master@{#31912}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed the comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -2 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +7 lines, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ahaas
5 years, 1 month ago (2015-11-09 08:41:22 UTC) #1
titzer
On 2015/11/09 08:41:22, ahaas wrote: lgtm other than comment nit
5 years, 1 month ago (2015-11-09 18:50:23 UTC) #2
titzer
https://codereview.chromium.org/1421163005/diff/1/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): https://codereview.chromium.org/1421163005/diff/1/src/x64/macro-assembler-x64.cc#newcode3201 src/x64/macro-assembler-x64.cc:3201: Set(dst, 64); // The result of tzcnt is 32 ...
5 years, 1 month ago (2015-11-09 18:50:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421163005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421163005/20001
5 years, 1 month ago (2015-11-10 08:41:01 UTC) #6
ahaas
On 2015/11/09 at 18:50:34, titzer wrote: > https://codereview.chromium.org/1421163005/diff/1/src/x64/macro-assembler-x64.cc > File src/x64/macro-assembler-x64.cc (right): > > https://codereview.chromium.org/1421163005/diff/1/src/x64/macro-assembler-x64.cc#newcode3201 ...
5 years, 1 month ago (2015-11-10 08:41:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-10 08:42:25 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 08:43:08 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a594ff73a989c48e23da6f3f06bf816b7bdc75ab
Cr-Commit-Position: refs/heads/master@{#31912}

Powered by Google App Engine
This is Rietveld 408576698