Support isExternal method on MethodMirror in the Dart VM. Not really intended for public consumptio…

Support isExternal method on MethodMirror in the Dart VM. Not really intended for public consumption. switch to using isExternal and using anonymous.

BUG=
R=alanknight@google.com, asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/688b69fb65f2c6c51a68df56551de484fd5d2eea

[Jacob, 2015-10-30 00:25:48]

jacobr@google.com changed reviewers:
+ alanknight@google.com, asiva@google.com

[Jacob, 2015-10-30 00:25:49]

asiva please review the dart vm changes. alanknight please review the
js_dartium.dart changes.

[Alan Knight, 2015-10-30 00:38:58]

lgtm

https://codereview.chromium.org/1421133003/diff/1/sdk/lib/js/dartium/js_darti...
File sdk/lib/js/dartium/js_dartium.dart (right):

https://codereview.chromium.org/1421133003/diff/1/sdk/lib/js/dartium/js_darti...
sdk/lib/js/dartium/js_dartium.dart:861: if (dartClass_instance is
html.DartHtmlDomObject && dartClass_instance is! JsObject)
There's a way it can be both?

[Jacob, 2015-10-30 00:41:24]

https://codereview.chromium.org/1421133003/diff/1/sdk/lib/js/dartium/js_darti...
File sdk/lib/js/dartium/js_dartium.dart (right):

https://codereview.chromium.org/1421133003/diff/1/sdk/lib/js/dartium/js_darti...
sdk/lib/js/dartium/js_dartium.dart:861: if (dartClass_instance is
html.DartHtmlDomObject && dartClass_instance is! JsObject)
On 2015/10/30 00:38:58, Alan Knight wrote:
> There's a way it can be both?

yep... and not just by accident.

@JS
class MyPolymerEvent implements html.MessageEvent {
  external get someFancyProperty;
}

[siva, 2015-10-30 02:09:17]

lgtm

https://codereview.chromium.org/1421133003/diff/20001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (left):

https://codereview.chromium.org/1421133003/diff/20001/runtime/lib/mirrors.cc#...
runtime/lib/mirrors.cc:1977: 
Extra line got deleted (we usually have two blank lines between functions)

[Jacob, 2015-10-30 02:16:03]

https://codereview.chromium.org/1421133003/diff/20001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (left):

https://codereview.chromium.org/1421133003/diff/20001/runtime/lib/mirrors.cc#...
runtime/lib/mirrors.cc:1977: 
On 2015/10/30 02:09:17, siva wrote:
> Extra line got deleted (we usually have two blank lines between functions)

Done.

[Jacob, 2015-10-30 02:17:15]

Committed patchset #2 (id:20001) manually as
688b69fb65f2c6c51a68df56551de484fd5d2eea (presubmit successful).