runtime/lib/mirrors.cc - Issue 1421133003: Support isExternal method on MethodMirror in the Dart VM. Not really intended for public consumptio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/mirrors.cc

Issue 1421133003: Support isExternal method on MethodMirror in the Dart VM. Not really intended for public consumptio… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: ran formatter on js_dartium.dart Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/mirrors.cc

diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc

index 4b0f2914d2453ab1291f5a6b17ab9d013007a256..848f67dec269e61d3597c3e6be6f389db92db356 100644

--- a/runtime/lib/mirrors.cc

+++ b/runtime/lib/mirrors.cc

@@ -278,6 +278,7 @@ static RawInstance* CreateMethodMirror(const Function& func,

kind_flags |= ((is_ctor && func.is_redirecting())

<< Mirrors::kRedirectingCtor);

kind_flags |= ((is_ctor && func.IsFactory()) << Mirrors::kFactoryCtor);

+ kind_flags |= (func.is_external() << Mirrors::kExternal);

args.SetAt(5, Smi::Handle(Smi::New(kind_flags)));

return CreateMirror(Symbols::_LocalMethodMirror(), args);

@@ -1974,7 +1975,6 @@ DEFINE_NATIVE_ENTRY(MethodMirror_source, 1) {

return func.GetSource();

}

siva 2015/10/30 02:09:17 Extra line got deleted (we usually have two blank

Jacob 2015/10/30 02:16:03 Done.

static RawInstance* CreateSourceLocation(const String& uri,

intptr_t line,

intptr_t column) {

« no previous file with comments | « runtime/lib/mirrors.h ('k') | runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »