third_party/WebKit/Source/core/frame/Frame.cpp - Issue 1421113006: Detach the globals of all frames, not just the main frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Frame.cpp

Issue 1421113006: Detach the globals of all frames, not just the main frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git cl try Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/Frame.cpp

diff --git a/third_party/WebKit/Source/core/frame/Frame.cpp b/third_party/WebKit/Source/core/frame/Frame.cpp

index 1abb7893f3556d9716237790ae5294ca493e6759..18b15546d3b4284a64a07bdf1ab25e3445553e8f 100644

--- a/third_party/WebKit/Source/core/frame/Frame.cpp

+++ b/third_party/WebKit/Source/core/frame/Frame.cpp

@@ -30,6 +30,7 @@

#include "config.h"

#include "core/frame/Frame.h"

+#include "bindings/core/v8/WindowProxyManager.h"

#include "core/dom/DocumentType.h"

#include "core/events/Event.h"

#include "core/frame/LocalDOMWindow.h"

@@ -90,6 +91,7 @@ DEFINE_TRACE(Frame)

void Frame::detach(FrameDetachType type)

{

ASSERT(m_client);

+ windowProxyManager()->clearWindowProxy();

dcheng 2015/10/30 15:49:46 Is there a reason to call this again here, btw? Bo

m_client->setOpener(0);

domWindow()->resetLocation();

disconnectOwnerElement();