third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp - Issue 1421113006: Detach the globals of all frames, not just the main frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp

Issue 1421113006: Detach the globals of all frames, not just the main frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git cl try Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.h ('k') | third_party/WebKit/Source/core/frame/Frame.cpp » ('j') | third_party/WebKit/Source/core/frame/Frame.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp

index 970faaf3c45c69d1d3558fe5496c82eb9cec4968..78b3196f087582dc738ebd36679f2e64efbe90d8 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp

@@ -47,18 +47,11 @@ WindowProxy* WindowProxyManager::windowProxy(DOMWrapperWorld& world)

return windowProxy;

}

-void WindowProxyManager::clearForClose()

+void WindowProxyManager::clearWindowProxy()

{

- m_windowProxy->clearForClose();

+ m_windowProxy->clearWindowProxy();

for (auto& entry : m_isolatedWorlds)

- entry.value->clearForClose();

-void WindowProxyManager::clearForNavigation()

- m_windowProxy->clearForNavigation();

- for (auto& entry : m_isolatedWorlds)

- entry.value->clearForNavigation();

+ entry.value->clearWindowProxy();

}

WindowProxy* WindowProxyManager::existingWindowProxy(DOMWrapperWorld& world)