Introduces window_finder_android.cc

chrome/chrome_browser_ui.gypi

Index: chrome/chrome_browser_ui.gypi
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi
index 374702fe49cca72fa33ece7498038ceea0b4d0c8..2aa533499da12ea5c8c21aed34f94643351a405e 100644
--- a/chrome/chrome_browser_ui.gypi
+++ b/chrome/chrome_browser_ui.gypi
@@ -2384,6 +2384,7 @@
       'browser/ui/views/tabs/tab_strip_layout.cc',
       'browser/ui/views/tabs/tab_strip_layout.h',
       'browser/ui/views/tabs/window_finder.h',
+      'browser/ui/views/tabs/window_finder_android.cc',
       'browser/ui/views/tabs/window_finder_chromeos.cc',
       'browser/ui/views/tabs/window_finder_mac.mm',
       'browser/ui/views/tabs/window_finder_win.cc',
@@ -2964,6 +2965,9 @@
                 ['enable_extensions==1', {
                   'sources': [ '<@(chrome_browser_ui_views_extensions_non_mac_sources)' ],
                 }],
+                ['use_ash==1 or OS=="android"', {

[sky, 2015/11/06 17:26:57]

This is a subtle and confusing place to put this include. I would rather you
list window_finder_impl.cc with all sources and exclude where appropriate.

[bshe, 2015/11/06 21:13:21]

I assume you mean include the file in "chrome_browser_ui_views_non_mac_sources".
It looks like non_mac_sources is used here and also when mac_views_browser is
true on mac platform. So I need to exclude them in two different places with
condition check for android and ash. It is still not easy to read.
Instead, I added a chrome_browser_ui_views_android_sources variable and the
condition checks seem easier to read. But
I need to duplicate window_finder_impl.* in this case. So not entirely sure this
approach is better. WDYT?

+                  'sources': [ 'browser/ui/views/tabs/window_finder_impl.cc' ],
+                }],
               ],
             }],
             ['enable_extensions==1', {